Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactoring matchers.SpatialMatcher #138

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

vvatanabe
Copy link
Member

@vvatanabe vvatanabe commented Aug 9, 2023

refactoring matchers.SpatialMatcher:

  • Extracted part of the process within the execute function into a separate function.
  • Applied google-java-format.
  • Removed the redundant extend function from BaseMatcher.
  • Made the regular expression object shiftedRx static to reduce the number of times it's created.
  • Changed the default ADJACENTS to private static final to minimize the number of instances created.
  • By storing the result of String.valueOf(charAt) in a variable and reusing it, the duplication of operations was reduced.

@coveralls
Copy link

Coverage Status

coverage: 92.378% (+0.03%) from 92.353% when pulling a52747d on refactoring-SpatialMatcher into 181cb40 on master.

@vvatanabe vvatanabe merged commit 2cfba5b into master Aug 9, 2023
3 checks passed
@vvatanabe vvatanabe deleted the refactoring-SpatialMatcher branch August 15, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants