Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactoring matchers.SequenceMatcher #140

Merged
merged 2 commits into from
Aug 12, 2023

Conversation

vvatanabe
Copy link
Member

refactoring matchers.SpatialMatcher:

  • Extracted part of the process within the execute function into a separate function.
  • Applied google-java-format.
  • Made the regular expression object LOWERCASE_PATTERN, UPPERCASE_PATTERN, DIGIT_PATTERN static to reduce the number of times it's created.
  • Defined literal values used in methods and within the class as constants for readability and change management.
  • Changed the regular expression's find function to matches function. (Switched from partial match to a complete match.)
  • Defined SequenceType as an inner class.

@coveralls
Copy link

Coverage Status

coverage: 92.49% (+0.1%) from 92.383% when pulling 9b04a8f on refactoring-SequenceMatcher into 6502a46 on master.

@vvatanabe vvatanabe merged commit c44f606 into master Aug 12, 2023
3 checks passed
@vvatanabe vvatanabe deleted the refactoring-SequenceMatcher branch August 15, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants