New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: refactoring matchers.L33tMatcher #141

Merged

vvatanabe merged 2 commits into master from refactoring-L33tMatcher

Aug 12, 2023

Member

vvatanabe commented Aug 12, 2023 •

edited

refactoring matchers. L33tMatcher:

Extracted part of the process within the execute function into a separate function.
Applied google-java-format.
Renamed the translate function in BaseMatcher to decodeL33tSpeak and moved it to L33tMatcher.
Changed type of L33T_TABLE to an UnmodifiableMap.
Reduced computational complexity by changing passwordChars in the relevantL33tSubTable function from HashMap<Character, Boolean> to HashSet<Character>.

vvatanabe added 2 commits

August 12, 2023 15:14


          style: format code and optimize imports in matchers.L33tMatcher

95e3fb9


          refactor: refactoring matchers.L33tMatcher

0f62469

coveralls commented Aug 12, 2023

coverage: 92.534% (+0.04%) from 92.49% when pulling 0f62469 on refactoring-L33tMatcher into c44f606 on master.

vvatanabe merged commit b7a3b2e into master

3 checks passed

vvatanabe deleted the refactoring-L33tMatcher branch

August 15, 2023 07:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment