MAINT: Minor include fixup in scalarmath after rebase and comment fixup

numpy · Oct 12, 2022 · d563343 · d563343
1 parent d9da02d
commit d563343
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/numpy/core/src/umath/scalarmath.c.src b/numpy/core/src/umath/scalarmath.c.src
@@ -26,14 +26,12 @@
 #include "binop_override.h"
 #include "npy_longdouble.h"
 
-#include "arraytypes.h"
 #include "array_coercion.h"
 #include "common.h"
 #include "can_cast_table.h"
 #include "umathmodule.h"
 
 #include "convert_datatype.h"
-#include "dtypemeta.h"
 
 
 /* TODO: Used for some functions, should possibly move these to npy_math.h */

diff --git a/numpy/core/tests/test_nep50_promotions.py b/numpy/core/tests/test_nep50_promotions.py
@@ -33,7 +33,8 @@ def test_nep50_examples():
     assert res.dtype == np.int64
 
     with pytest.warns(UserWarning, match="result dtype changed"):
-        # Note: Overflow would be nice, but does not warn with change warning
+        # Note: For "weak_and_warn" promotion state the overflow warning is
+        #       unfortunately not given (because we use the full array path).
         with np.errstate(over="raise"):
             res = np.uint8(100) + 200
     assert res.dtype == np.uint8