Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Add support for symbol to polynomial package #16154

Merged
merged 37 commits into from Jun 1, 2022
Merged

ENH: Add support for symbol to polynomial package #16154

merged 37 commits into from Jun 1, 2022

Commits on Jun 1, 2022

  1. WIP: Start adding a symbol to the classes in poly pkg

    @rossbar
    rossbar committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    4569d1c View commit details
    Browse the repository at this point in the history

  2. WIP: Started adding tests for symbol.

    @rossbar
    rossbar committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    3fecd79 View commit details
    Browse the repository at this point in the history

  3. Added tests for bad symbol input to __init__

    @rossbar
    rossbar committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    dbd3259 View commit details
    Browse the repository at this point in the history

  4. Parametrized test for bad symbol input

    @rossbar
    rossbar committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    bb3a059 View commit details
    Browse the repository at this point in the history

  5. Added positive examples for symbol input validation.

    @rossbar
    rossbar committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    10d60fc View commit details
    Browse the repository at this point in the history

  6. Added TODO to remind about printing latex symbols

    @rossbar
    rossbar committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    d326b92 View commit details
    Browse the repository at this point in the history

  7. Add symbol check and init to all relevant ABCPoly methods. 

    Needs testing.
    @rossbar
    rossbar committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    4bba5ae View commit details
    Browse the repository at this point in the history

  8. Added symbol to polybase repr 

    Updated tests for repr
    @rossbar
    rossbar committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    9949984 View commit details
    Browse the repository at this point in the history

  9. WIP: Add tests for num ops w/ polys w/ symbols

    @rossbar
    rossbar committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    e43b348 View commit details
    Browse the repository at this point in the history

  10. Added test of unicode char as symbol

    @rossbar
    rossbar committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    505d752 View commit details
    Browse the repository at this point in the history

  11. Added test for changing symbol via __init__

    @rossbar
    rossbar committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    fe889c7 View commit details
    Browse the repository at this point in the history

  12. Reorganized tests into unary/binary ops. 

    Parametrized binary ops tests for poly symbol to test both
polynomials and arrays.

Created new class to encapsulate unary operators (pow, neg, etc)
    @rossbar
    rossbar committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    a2f9c62 View commit details
    Browse the repository at this point in the history

  13. Added tests for RH ops.

    @rossbar
    rossbar committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    8ec381e View commit details
    Browse the repository at this point in the history

  14. Added tests that math ops fail for poly of diff. symb.

    @rossbar
    rossbar committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    6e6ad3e View commit details
    Browse the repository at this point in the history

  15. Added equality check tests for poly with symbol

    @rossbar
    rossbar committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    dc667f7 View commit details
    Browse the repository at this point in the history

  16. Test that symbol is kept for creation/manipulation methods

    @rossbar
    rossbar committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    59f822e View commit details
    Browse the repository at this point in the history

  17. Added tests for class methods that create poly instance.

    @rossbar
    rossbar committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    e8de469 View commit details
    Browse the repository at this point in the history

  18. Make 'symbol' a RO property of ABCPolyBase.

    @rossbar
    rossbar committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    e77c86d View commit details
    Browse the repository at this point in the history

  19. Added TODO to remind about printing latex symbols

    @rossbar
    rossbar committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    5b2f48a View commit details
    Browse the repository at this point in the history

  20. WIP: Add tests for num ops w/ polys w/ symbols

    @rossbar
    rossbar committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    9b24b5e View commit details
    Browse the repository at this point in the history

  21. Added test of unicode char as symbol

    @rossbar
    rossbar committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    97a8ac2 View commit details
    Browse the repository at this point in the history

  22. Added test for changing symbol via __init__

    @rossbar
    rossbar committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    6f0968e View commit details
    Browse the repository at this point in the history

  23. Reorganized tests into unary/binary ops. 

    Parametrized binary ops tests for poly symbol to test both
polynomials and arrays.

Created new class to encapsulate unary operators (pow, neg, etc)
    @rossbar
    rossbar committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    1abcd49 View commit details
    Browse the repository at this point in the history

  24. Added tests for RH ops. 

    Added tests for class methods that create poly instance.

Make 'symbol' a RO property of ABCPolyBase.

Updated routines.polynomials.classes for refguide_check
    @rossbar
    rossbar committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    094bda3 View commit details
    Browse the repository at this point in the history

  25. Make __str__ take symbol into account

    @rossbar
    rossbar committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    a7d4f5e View commit details
    Browse the repository at this point in the history

  26. Fixed a test

    @rossbar
    rossbar committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    ef52286 View commit details
    Browse the repository at this point in the history

  27. TST: Basic test of poly symbol printing

    @rossbar
    rossbar committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    186340f View commit details
    Browse the repository at this point in the history

  28. DOC: Update symbol wording and add to docstrings.

    @rossbar
    rossbar committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    a81ac85 View commit details
    Browse the repository at this point in the history

  29. MAINT: Remove redundant property def

    @rossbar
    rossbar committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    eee85dd View commit details
    Browse the repository at this point in the history

  30. ENH,TST: Add symbol to _repr_latex_. 

     * Add tests for symbol in TestLatexRepr
    @rossbar
    rossbar committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    d0609ab View commit details
    Browse the repository at this point in the history

  31. STY: make linter happy.

    @rossbar
    rossbar committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    4cc3721 View commit details
    Browse the repository at this point in the history

  32. DOC: fix failing refguide example.

    @rossbar
    rossbar committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    12bf51c View commit details
    Browse the repository at this point in the history

  33. ENH: limit allowable symbols to identifiers. 

    Raise informative exceptions when the symbol input is invalid.

Co-authored-by: Warren Weckesser <warren.weckesser@gmail.com>
    @rossbar @WarrenWeckesser
    rossbar and WarrenWeckesser committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    0ab3580 View commit details
    Browse the repository at this point in the history

  34. STY: make linter happy.

    @rossbar
    rossbar committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    4c85ddf View commit details
    Browse the repository at this point in the history

  35. DOC: Update symbol parameter description. 

    Match new definition and add versionadded.
    @rossbar
    rossbar committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    1c99edd View commit details
    Browse the repository at this point in the history

  36. TST: compose poly instances w/ different symbols. 

    Co-authored-by: Warren Weckesser <warren.weckesser@gmail.com>
    @rossbar @WarrenWeckesser
    rossbar and WarrenWeckesser committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    5fdfef5 View commit details
    Browse the repository at this point in the history

  37. DOC: Add release note for polynomial symbol.

    @rossbar
    rossbar committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    da2fae3 View commit details
    Browse the repository at this point in the history