Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: Finalize unravel_index dims alias for shape keyword #17900

Merged
merged 1 commit into from Dec 3, 2020

Conversation

seberg
Copy link
Member

@seberg seberg commented Dec 3, 2020

The argument was renamed to shape and deprecated since NumPy 1.16,
so the deprecation can now be finalized.

The argument was renamed to `shape` and deprecated since NumPy 1.16,
so the deprecation can now be finalized.
@seberg seberg force-pushed the finalize-unravel-index-dims-dep branch from 5eb7208 to d54e2dc Compare December 3, 2020 02:25
@mattip
Copy link
Member

mattip commented Dec 3, 2020

close/reopen to restart builds

@mattip mattip closed this Dec 3, 2020
@mattip mattip reopened this Dec 3, 2020
@mattip mattip merged commit 92bf2f6 into numpy:master Dec 3, 2020
@mattip
Copy link
Member

mattip commented Dec 3, 2020

Thanks @seberg

@seberg seberg deleted the finalize-unravel-index-dims-dep branch December 3, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants