MAINT: Use towncrier build explicitly #18794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without any argument towncrier defaults to `build`. But towncrier added a `--version` argument to just print the towncrier version. NumPy relies on passing `--version` which collides. Even if towncrier might revert the change, using `towncrier build` explicitly just doesn't hurt. Closes numpygh-18788
We were installing towncrier from the github master branch because there had been no releases with the needed fixes. That has changed with the recent release of versions 19.9.0 and 21.3.0.
charris
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #18790 and #18792.
Without any argument towncrier defaults to build. But towncrier
added a --version argument to just print the towncrier version.
NumPy relies on passing --version which collides. Even if
towncrier might revert the change, using towncrier build explicitly
just doesn't hurt.
Also use recent release of towncrier on PyPI instead of building
from the master branch.
Closes gh-18788