BLD: remove unnecessary flag -faltivec on macOS
#18923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supporting PowerPC/AltiVec on macOS is no longer necessary, even if the Mac/G5 is still running having `-faltivec` or replacing it with the new AltiVec flag `-maltivec` wouldn't increase that much performance without raw SIMD. note: the flag was enabled on non-intel platforms which causes fatal build errors on macOS/arm64.
This was referenced Nov 3, 2021
|
@charris This should have been made conditional, not removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #18900.
Supporting PowerPC/AltiVec on macOS is no longer necessary,
even if the Mac/G5 is still running having
-faltivecorreplacing it with the new AltiVec flag
-maltivecwouldn'tincrease that much performance without raw SIMD.
note: the flag was enabled on non-intel platforms which
causes fatal build errors on macOS/arm64.