Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT, CI: treats _SIMD module build warnings as errors through CI only #18924

Merged
merged 1 commit into from May 6, 2021

Conversation

charris
Copy link
Member

@charris charris commented May 5, 2021

Partial backport of #18903.

Closes #18297

@seiko2plus
Copy link
Member

seiko2plus commented May 6, 2021

@charris, #18903 comes with "two" commits the first one is the only matter to backport. if you think it necessary to get both patches then we will need to backport #17791 too or maybe just remove export CFLAGS="$CFLAGS -Werror=undef" from the second patch.

@charris
Copy link
Member Author

charris commented May 6, 2021

@seiko2plus Thanks for the info, it saved me from needing to look for the missing PR :) Backports become trickier towards the end of the support window.

@charris
Copy link
Member Author

charris commented May 6, 2021

Lets try with just the first patch. I confess I don't see what is does :)

@seiko2plus
Copy link
Member

I confess I don't see what is does :)

LOL, I think it's just fine to have only this patch.

@charris charris merged commit c447619 into numpy:maintenance/1.20.x May 6, 2021
@charris charris deleted the backport-18903 branch May 7, 2021 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants