New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEP: Deprecate 4 ndarray.ctypes
methods
#19031
Conversation
* `get_data` * `get_shape` * `get_strides` * `get_as_parameter`
Co-Authored-By: Sebastian Berg <sebastian@sipsolutions.net>
Co-Authored-By: Eric Wieser <425260+eric-wieser@users.noreply.github.com>
Co-Authored-By: Eric Wieser <425260+eric-wieser@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I would have deprecated them at the time, but the bugfix had already turned into a refactor and I didn't want to throw in a deprecation in the same PR.
Thanks! That one travis run has beeing making problems. I am going to put it in, since I don't expect complains on the mailing list. If they come, happy to revert :). |
Xref #19029 (comment).
Four methods of the
ndarray.ctypes
object have been deprecated, as they are (undocumentated) implementation artifacts of their respective property. They were originally kept around for the sake of backwards compatibility (79baef7), but as this was three years ago it should be safe to formally deprecate them by now.numpy/numpy/core/_internal.py
Lines 353 to 357 in bfb1ac8