Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Implement the DLPack Array API protocols for ndarray. #19083
ENH: Implement the DLPack Array API protocols for ndarray. #19083
Changes from 17 commits
a888ae8
3163d57
eb6ee26
3e5b274
e12695d
094e0aa
158c728
9ebee26
e83b8d8
e167da7
a4cc97a
f96aaa2
0c992dc
ef04f59
ba8fcbe
c38b7f3
f6076ee
5b94a03
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interestingly, if we could get
builtins.PyCapsule
in typeshed annotated as a parameterizable type,then it would in principle be possible for static type checkers to read, e.g., the underlying shape and dtype.
The only thing that users or libraries would have to do here is declare the necessary annotations.
Perhaps something to consider for the future?
Examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll consider this as out of scope of this PR for now, but will leave the conversation unresolved for visibility.