Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Adding keepdims to np.argmin,np.argmax #19211

Merged
merged 38 commits into from Jul 7, 2021
Merged

ENH: Adding keepdims to np.argmin,np.argmax #19211

merged 38 commits into from Jul 7, 2021

Commits on Jun 10, 2021

  1. keepdims added to np.argmin,np.argmax

    @czgdp1807
    czgdp1807 committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    0e5817e View commit details
    Browse the repository at this point in the history

  2. Added release notes entry

    @czgdp1807
    czgdp1807 committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    5d66427 View commit details
    Browse the repository at this point in the history

  3. tested for axis=None,keepdims=True

    @czgdp1807
    czgdp1807 committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    4d8f3af View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review

    @czgdp1807
    czgdp1807 committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    aa2adc9 View commit details
    Browse the repository at this point in the history

  5. updated interface

    @czgdp1807
    czgdp1807 committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    f7d4df4 View commit details
    Browse the repository at this point in the history

  6. updated interface

    @czgdp1807
    czgdp1807 committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    1e725c7 View commit details
    Browse the repository at this point in the history

  7. API changed, implementation to be done

    @czgdp1807
    czgdp1807 committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    4d2bfab View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2021

  1. Added reshape approach to C implementation

    @czgdp1807
    czgdp1807 committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    09433d6 View commit details
    Browse the repository at this point in the history

  2. buggy implementation without reshape

    @czgdp1807
    czgdp1807 committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    8ea07b4 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2021

  1. TestArgMax, TestArgMin fixed, comments added

    @czgdp1807
    czgdp1807 committed Jun 12, 2021
    Configuration menu
    Copy the full SHA
    aa73907 View commit details
    Browse the repository at this point in the history

  2. Fixed for matrix

    @czgdp1807
    czgdp1807 committed Jun 12, 2021
    Configuration menu
    Copy the full SHA
    22fbb06 View commit details
    Browse the repository at this point in the history

  3. removed unrequired changes

    @czgdp1807
    czgdp1807 committed Jun 12, 2021
    Configuration menu
    Copy the full SHA
    d04946f View commit details
    Browse the repository at this point in the history

  4. fixed CI failure

    @czgdp1807
    czgdp1807 committed Jun 12, 2021
    Configuration menu
    Copy the full SHA
    512b359 View commit details
    Browse the repository at this point in the history

  5. fixed linting issue

    @czgdp1807
    czgdp1807 committed Jun 12, 2021
    Configuration menu
    Copy the full SHA
    da3df5b View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2021

  1. PyArray_ArgMaxKeepdims now only modifies shape and strides

    @czgdp1807
    czgdp1807 committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    828df3b View commit details
    Browse the repository at this point in the history

  2. Comments added to PyArray_ArgMaxKeepdims

    @czgdp1807
    czgdp1807 committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    91e7530 View commit details
    Browse the repository at this point in the history

  3. Updated implementation of PyArray_ArgMinKeepdims to match with PyArra… 

    …y_ArgMaxKeepdims
    @czgdp1807
    czgdp1807 committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    a1c0faa View commit details
    Browse the repository at this point in the history

  4. Testing complete for PyArray_ArgMinKeepdims and PyArray_ArgMaxKeepdims

    @czgdp1807
    czgdp1807 committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    fa5839b View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2021

  1. PyArray_ArgMinWithKeepdims both keepdims=True and keepdims=False

    @czgdp1807
    czgdp1807 committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    2cd3ff1 View commit details
    Browse the repository at this point in the history

  2. matched implementation of PyArray_ArgMaxKeepdims and PyArray_ArgMinKe… 

    …epdims
    @czgdp1807
    czgdp1807 committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    124abe3 View commit details
    Browse the repository at this point in the history

  3. simplified implementation

    @czgdp1807
    czgdp1807 committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    6bd9f4c View commit details
    Browse the repository at this point in the history

  4. Added missing comment

    @czgdp1807
    czgdp1807 committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    55a85d3 View commit details
    Browse the repository at this point in the history

  5. removed unwanted header

    @czgdp1807
    czgdp1807 committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    568251e View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2021

  1. addressed all the reviews

    @czgdp1807
    czgdp1807 committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    9260d40 View commit details
    Browse the repository at this point in the history

  2. Removing unwanted changes

    @czgdp1807
    czgdp1807 committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    06d9610 View commit details
    Browse the repository at this point in the history

  3. fixed docs

    @czgdp1807
    czgdp1807 committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    2112709 View commit details
    Browse the repository at this point in the history

  4. Added new lines

    @czgdp1807
    czgdp1807 committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    e0dd74e View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2021

  1. restored annotations

    @czgdp1807
    czgdp1807 committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    11d7e33 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'keepdims' of https://github.com/czgdp1807/numpy into ke… 

    …epdims
    @czgdp1807
    czgdp1807 committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    eec3e2f View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2021

  1. parametrized test

    @czgdp1807
    czgdp1807 committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    4c9f113 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Sebastian Berg <sebastian@sipsolutions.net>
    @czgdp1807 @seberg
    czgdp1807 and seberg committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    db9c704 View commit details
    Browse the repository at this point in the history

  2. keyword handling now done in np.argmin/np.argmax

    @czgdp1807
    czgdp1807 committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    11cd597 View commit details
    Browse the repository at this point in the history

  3. corrected indendation

    @czgdp1807
    czgdp1807 committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    bb906bf View commit details
    Browse the repository at this point in the history

  4. used with pytest.riases(ValueError)

    @czgdp1807
    czgdp1807 committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    3b72f59 View commit details
    Browse the repository at this point in the history

  5. fixed release notes

    @czgdp1807
    czgdp1807 committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    66adc84 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2021

  1. removed PyArray_ArgMaxWithKeepdims and PyArray_ArgMinWithKeepdims fro… 

    …m public C-API
    @czgdp1807
    czgdp1807 committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    4be86dd View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
    @czgdp1807 @eric-wieser
    czgdp1807 and eric-wieser committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    8f9f108 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
    @czgdp1807 @eric-wieser
    czgdp1807 and eric-wieser committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    c55aaea View commit details
    Browse the repository at this point in the history