Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: factored out _PyArray_ArgMinMaxCommon #19440

Merged
merged 4 commits into from Jul 12, 2021
Merged

MAINT: factored out _PyArray_ArgMinMaxCommon #19440

merged 4 commits into from Jul 12, 2021

Conversation

czgdp1807
Copy link
Member

@czgdp1807 czgdp1807 commented Jul 9, 2021 •
edited

@czgdp1807
Copy link
Member Author

I will refactor tests in the next commits.

@czgdp1807 czgdp1807 changed the title [WIP] MAINT: factored out _PyArray_ArgMinMaxCommon MAINT: factored out _PyArray_ArgMinMaxCommon Jul 10, 2021
@czgdp1807
Copy link
Member Author

This is ready. Thanks.

@czgdp1807
Copy link
Member Author

Seems like the tests timed out.

@mattip mattip merged commit c750d24 into numpy:main Jul 12, 2021
@mattip
Copy link
Member

mattip commented Jul 12, 2021

Thanks @czgdp1807

@czgdp1807 czgdp1807 deleted the refac branch July 12, 2021 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seberg seberg seberg left review comments

@mattip mattip mattip left review comments

Assignees
No one assigned
Labels
03 - Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@czgdp1807 @mattip @seberg