Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLD: Add clang -ftrapping-math also for compiler_so #19479

Merged
merged 3 commits into from Jul 18, 2021
Merged

BLD: Add clang -ftrapping-math also for compiler_so #19479

merged 3 commits into from Jul 18, 2021

Commits on Jul 15, 2021

  1. BLD: Use -ftrapping-math for clang and for _so 

    Apparently, there is a second `compiler_so` that is actually the
main compiler being used, and modifying only the first one is just
futile.

The old try was `-ffp-exception-behavior=strict`, but that seems to
be a fairly new addition (and doesn't even work on MacOS with 10.0)

`-ftrapping-math` seems to be the older, equivalent option.
    @seberg
    seberg committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    e7d1841 View commit details
    Browse the repository at this point in the history

  2. DOC: Modify comment to note that the volatile can eventually be removed

    @seberg
    seberg committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    3b564f7 View commit details
    Browse the repository at this point in the history

  3. DOC: Add release note for -ftrapping-math on clang

    @seberg
    seberg committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    f1d082c View commit details
    Browse the repository at this point in the history