ENH: Add support for windows on arm targets #19513

niyas-sait · 2021-07-18T21:56:38Z

No description provided.

charris · 2021-07-18T22:01:34Z

IIRC, we are still waiting for azure to add support for Windows on arm so that we can test it. It has been in the pipeline for several months. . .

numpy/core/include/numpy/npy_cpu.h

numpy/random/src/philox/philox.h

…r WoA

bashtage · 2021-07-21T09:33:39Z

Patch LGTM. Probably need to wire up an ARM64/Windows host to really know. @nsait-linaro do you have a suitable system locally and does it pass all tests?

niyas-sait · 2021-07-22T11:27:03Z

Patch LGTM. Probably need to wire up an ARM64/Windows host to really know. @nsait-linaro do you have a suitable system locally and does it pass all tests?

Yes, Please see test results below

====================================== short test summary info ==================================================================
FAILED numpy\core\tests\test_scalarprint.py::TestRealScalars::test_dragon4 - AssertionError:
=======================1 failed, 15456 passed, 513 skipped, 19 xfailed, 2 warnings in 927.26s (0:15:27) ===========

The failing test case seems to be due to a c runtime issue. The precision for pow is slightly lower on windows/arm64 targets , I will raise this separately with Microsoft.

In the meantime we might need to workaround the issue in the test. Either we can skip the test or make one small change to the testcase as shown below.

-        assert_equal(fpos64(0.5**(1022 + 52), unique=False, precision=1074),
+        assert_equal(fpos64(8e-323, unique=False, precision=1074),

Any recommendation on how to progress ?

niyas-sait · 2021-07-22T11:29:05Z

IIRC, we are still waiting for azure to add support for Windows on arm so that we can test it. It has been in the pipeline for several months. . .

In Linaro, we have a couple of windows on arm machines and might be able to set up a CI flow. I think this patch doesn't have to be blocked due to CI as it is not introducing any regression and works locally. Do you know who would be the right person to talk to regarding setting up CI for WoA targets?

bashtage · 2021-07-22T13:56:06Z

You can either conditionally skip the test or set the tolerance conditional on Win/ARM64. The latter is probably more useful.

charris · 2021-07-22T14:07:28Z

Do you know who would be the right person to talk to regarding setting up CI for WoA targets?

See #17804, we seem to have lost that PR, it is still open. @zooba is the Microsoft contact in that PR.

…dows C RT for arm64

niyas-sait · 2021-07-23T07:32:44Z

Tests are all passing and can be merged if there are no concerns.

niyas-sait · 2021-07-24T10:28:05Z

@charris / @bashtage - Keen to get this merged. Tests are all passing and let me know if anything more needs to be done to accept this PR

numpy/core/include/numpy/npy_cpu.h

mattip

Other than adding a comment for the new MSVC-specific macro, LGTM. Does mingw64 support ARM compilation?

Co-authored-by: Matti Picus <matti.picus@gmail.com>

niyas-sait · 2021-07-25T11:55:55Z

Other than adding a comment for the new MSVC-specific macro, LGTM. Does mingw64 support ARM compilation?

I don't think mingw64 has support for arm targets yet. I am not sure though.

bashtage · 2021-07-26T09:24:00Z

LGTM and hopefully could be backported to 1.21.x so that Windows ARM users could have NumPy.

mattip · 2021-07-26T10:14:38Z

Does OpenBLAS support ARM64 on windows? In order to truly support this we should have some kind of BLAS backend

bashtage · 2021-07-26T10:16:03Z

I was wondering if there are any Fortran compilers for Windows ARM64. This would be a big blocker for SciPy I think.

niyas-sait · 2021-07-26T10:17:50Z

I was wondering if there are any Fortran compilers for Windows ARM64. This would be a big blocker for SciPy I think.

flag-new has support for windows arm64. I have used build from https://github.com/kaadam/flang/releases/tag/v0.1 and worked

niyas-sait · 2021-07-27T11:03:04Z

Does OpenBLAS support ARM64 on windows? In order to truly support this we should have some kind of BLAS backend

Unfortunately, OpenBLAS doesn't support arm64/windows yet. This could be a blocker for scipy and related packages.

niyas-sait · 2021-07-27T11:03:45Z

@mattip / @bashtage / @charris - Can we merge this PR ?

bashtage · 2021-07-27T11:07:36Z

I second support for early merge. NumPy + Lapack Lite is a lot better Python without NumPy. It also starts letting downstream projects accept patches that would be necessary for Win/ARM64, e.g., pandas, if needed.

mattip · 2021-07-27T11:40:48Z

This needs a new_feature release note, see the README for instructions. Probably should mention "preliminary support" and "no OpenBLAS"

niyas-sait · 2021-07-27T11:57:38Z

This needs a new_feature release note, see the README for instructions. Probably should mention "preliminary support" and "no OpenBLAS"

Updated branch with release notes

charris · 2021-07-27T20:09:01Z

Thanks @nsait-linaro .

* add support for windows on arm targets * Philox: Use _umulh intrinsic for ARM64 target * CPU Detection: Refactor to avoid separate pre-processor definition for WoA * adapt test_dragon4 to avoid using pow (**) to workaround issue in windows C RT for arm64 * Update numpy/core/include/numpy/npy_cpu.h Co-authored-by: Matti Picus <matti.picus@gmail.com> * add release note for numpy windows/arm64 support * Update 19513.new_feature.rst Co-authored-by: Matti Picus <matti.picus@gmail.com> Co-authored-by: Charles Harris <charlesr.harris@gmail.com>

niyas-sait · 2021-08-17T10:41:41Z

I've managed to build OpenBLAS (BLAS+LAPACK) for win-arm64 and configured NumPy to use it with site.cfg. Tests all are passing. But I wanted to confirm if numpy is really using the LAPACK routines. Does anyone know what would be the best way to do a quick sanity test to check this specifically? @charris , @mattip , @bashtage - could you help ?

mattip · 2021-08-17T10:51:59Z

If you built it like our CI does, you should have a dll in site-packages/numpy/.libs something like libopenblas.GK7GX5KEQ4F6UYO3P26ULGBQYHGQO7J4.gfortran-win_amd64.dll (but of course not amd64. If you stop python and rename this file, then start python, numpy will not longer successfully work since this file will be missing.

bashtage · 2021-08-17T13:03:50Z

You could turn on open blas debug information to see that it is loaded OPENBLAS_VERBOSE=2.

bashtage · 2021-08-17T13:04:21Z

If tools like process explorer are available for ARM, you could also check that the dll is loaded.

add support for windows on arm targets

f23957d

bashtage reviewed Jul 19, 2021

View reviewed changes

numpy/core/include/numpy/npy_cpu.h Outdated Show resolved Hide resolved

bashtage reviewed Jul 19, 2021

View reviewed changes

numpy/random/src/philox/philox.h Show resolved Hide resolved

niyas-sait added 2 commits July 19, 2021 18:09

Philox: Use _umulh intrinsic for ARM64 target

d72b973

CPU Detection: Refactor to avoid separate pre-processor definition fo…

6eed796

…r WoA

adapt test_dragon4 to avoid using pow (**) to workaround issue in win…

75d85f1

…dows C RT for arm64

mattip reviewed Jul 25, 2021

View reviewed changes

numpy/core/include/numpy/npy_cpu.h Show resolved Hide resolved

mattip approved these changes Jul 25, 2021

View reviewed changes

Update numpy/core/include/numpy/npy_cpu.h

9471c02

Co-authored-by: Matti Picus <matti.picus@gmail.com>

mattip added the 56 - Needs Release Note. Needs an entry in doc/release/upcoming_changes label Jul 27, 2021

add release note for numpy windows/arm64 support

6ce34c3

charris changed the title ~~add support for windows on arm targets~~ ENH: Add support for windows on arm targets Jul 27, 2021

github-actions bot added the 01 - Enhancement label Jul 27, 2021

charris added the 09 - Backport-Candidate PRs tagged should be backported label Jul 27, 2021

Update 19513.new_feature.rst

3ab6a59

charris merged commit 77bc322 into numpy:main Jul 27, 2021

charris mentioned this pull request Jul 27, 2021

ENH, BLD: Add windows arm64 support #17804

Closed

charris removed the 56 - Needs Release Note. Needs an entry in doc/release/upcoming_changes label Aug 12, 2021

charris mentioned this pull request Aug 12, 2021

ENH: Add support for windows on arm targets #19660

Merged

charris removed the 09 - Backport-Candidate PRs tagged should be backported label Aug 12, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ENH: Add support for windows on arm targets #19513

ENH: Add support for windows on arm targets #19513

niyas-sait commented Jul 18, 2021

charris commented Jul 18, 2021

bashtage commented Jul 21, 2021

niyas-sait commented Jul 22, 2021

niyas-sait commented Jul 22, 2021

bashtage commented Jul 22, 2021

charris commented Jul 22, 2021

niyas-sait commented Jul 23, 2021

niyas-sait commented Jul 24, 2021

mattip left a comment

niyas-sait commented Jul 25, 2021

bashtage commented Jul 26, 2021

mattip commented Jul 26, 2021

bashtage commented Jul 26, 2021

niyas-sait commented Jul 26, 2021

niyas-sait commented Jul 27, 2021

niyas-sait commented Jul 27, 2021

bashtage commented Jul 27, 2021

mattip commented Jul 27, 2021

niyas-sait commented Jul 27, 2021

charris commented Jul 27, 2021

niyas-sait commented Aug 17, 2021

mattip commented Aug 17, 2021

bashtage commented Aug 17, 2021

bashtage commented Aug 17, 2021

ENH: Add support for windows on arm targets #19513

ENH: Add support for windows on arm targets #19513

Conversation

niyas-sait commented Jul 18, 2021

charris commented Jul 18, 2021

bashtage commented Jul 21, 2021

niyas-sait commented Jul 22, 2021

niyas-sait commented Jul 22, 2021

bashtage commented Jul 22, 2021

charris commented Jul 22, 2021

niyas-sait commented Jul 23, 2021

niyas-sait commented Jul 24, 2021

mattip left a comment

Choose a reason for hiding this comment

niyas-sait commented Jul 25, 2021

bashtage commented Jul 26, 2021

mattip commented Jul 26, 2021

bashtage commented Jul 26, 2021

niyas-sait commented Jul 26, 2021

niyas-sait commented Jul 27, 2021

niyas-sait commented Jul 27, 2021

bashtage commented Jul 27, 2021

mattip commented Jul 27, 2021

niyas-sait commented Jul 27, 2021

charris commented Jul 27, 2021

niyas-sait commented Aug 17, 2021

mattip commented Aug 17, 2021

bashtage commented Aug 17, 2021

bashtage commented Aug 17, 2021