Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLD: Add LoongArch support #19527

Merged
merged 2 commits into from Aug 12, 2021
Merged

BLD: Add LoongArch support #19527

merged 2 commits into from Aug 12, 2021

Conversation

loongson-zn
Copy link
Contributor

Add LoongArch support, please review, thanks!

@github-actions github-actions bot added the 36 - Build Build related PR label Jul 20, 2021
@mattip
Copy link
Member

mattip commented Jul 20, 2021

Could you explain what you are trying to do? So far this does not look useful.

@loongson-zn
Copy link
Contributor Author

loongson-zn commented Jul 20, 2021 •
edited

Could you explain what you are trying to do? So far this does not look useful.

@mattip
It's PR is to solve compilation failure on LoongArch architecture.
LoongArch is a new instruction set. The official website is not ready yet.
Our development work is ongoing. At present, we have completed the initial version development based on Debian 10.
Binutils has identified EM_LOONGARCH is 258, I hope numpy can accept this patch. Thanks.

https://en.wikipedia.org/wiki/Loongson

@mattip
Copy link
Member

mattip commented Jul 20, 2021

I see, that indeed is shown at https://wiki.debian.org/ArchitectureSpecificsMemo#Summary

@mattip
Copy link
Member

mattip commented Jul 20, 2021

.. but with a note saying "The architecture name has not yet been proposed for integration into dpkg". Is there a chance the name will change?

@loongson-zn
Copy link
Contributor Author

@mattip
The upstream submission is our current the main work, so I don’t think the name will change.

@loongson-zn loongson-zn mentioned this pull request Jul 20, 2021
Merged
@charris
Copy link
Member

charris commented Aug 11, 2021

@loongson-zn Could you add a release note? See doc/release/upcoming_changes for examples, the heading should be new_feature.

@charris charris added the 56 - Needs Release Note. Needs an entry in doc/release/upcoming_changes label Aug 11, 2021
@charris charris merged commit a467114 into numpy:main Aug 12, 2021
@charris
Copy link
Member

charris commented Aug 12, 2021

Thanks @loongson-zn .

@cheungxi cheungxi mentioned this pull request Mar 26, 2022
Merged
@loongson-zn loongson-zn mentioned this pull request May 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
36 - Build Build related PR 56 - Needs Release Note. Needs an entry in doc/release/upcoming_changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@loongson-zn @mattip @charris