BUG: Fix an issue wherein importing numpy.typing could raise
#19533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Sebastian Berg <sebastian@sipsolutions.net>
BvB93
added
00 - Bug
08 - Backport
BvB93
changed the title
numpy.typing could raise
BvB93
changed the title
numpy.typing could raisenumpy.typing could raise
|
Thanks Bas. |
jjpr-mit
added a commit
to brain-score/brainio
that referenced
this pull request
Jul 23, 2021
jjpr-mit
added a commit
to brain-score/brainio
that referenced
this pull request
Jul 23, 2021
jjpr-mit
added a commit
to brain-score/brainio
that referenced
this pull request
Jul 23, 2021
* main: numpy 1.21.1 introduced a bug: numpy/numpy#19533 has the fix. (#8)
jjpr-mit
added a commit
to brain-score/brainio
that referenced
this pull request
Mar 9, 2022
* main: Add documentation (#16) Handle catalog duplicates gracefully (#15) Update to keep track of catalog files. (#11) Some methods in xarray 0.19.0 return a DataArray where they used to return an appropriate subclass of DataAssembly. (#9) Travis badge (#7) numpy 1.21.1 introduced a bug: numpy/numpy#19533 has the fix. (#8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #19521
Backport of #19525 in addition to two fixes for the to-be closed issue.
On a semi-frequent we're running into issues with numpy.typing when the following 2 conditions are met:
Ideally we'd just run a CI job without typing-extensions installed and see if the tests run as expected
but unfortunately this is not possible, as it is an (indirect) hard dependency of pytest.
This PR instead opts for an alternative approach: the test introduced herein reloads the numpy.typing
submodules after manually invalidating typing-extensions, thus making the package inaccessible as if it
weren't installed in the first place.