Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: add missing dunder method to nditer type hints #19652

Merged
merged 2 commits into from Aug 12, 2021

Conversation

BvB93
Copy link
Member

@BvB93 BvB93 commented Aug 12, 2021

Backport of #19554

Closes #19551

The presence of __getattr__ is not sufficient to enable all protocols so explicitely add the dunder methods supported by nditer
@BvB93 BvB93 added 08 - Backport Used to tag backport PRs Static typing labels Aug 12, 2021
@BvB93 BvB93 added this to the 1.21.2 release milestone Aug 12, 2021
@charris charris merged commit 27d71dc into numpy:maintenance/1.21.x Aug 12, 2021
@charris
Copy link
Member

charris commented Aug 12, 2021

Thanks Bas.

@BvB93 BvB93 deleted the dunders branch August 16, 2021 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants