Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD, SIMD: Fix testing extra checks when -Werror isn't applicable for Clang #19656

Merged
merged 1 commit into from Aug 12, 2021

Conversation

charris
Copy link
Member

@charris charris commented Aug 12, 2021

Backport of #19642.

In certain cases -Werror gets skipped during the availability test due
to "unused arguments" warnings. To solve the issue, -Werror-implicit-function-declaration
was added as a secondary flag, which is enough to guarantee the sanity of the testing process
when it comes to testing the availability of certain intrinsics.

closes #19624

…or Clang.

  In certain cases `-Werror` gets skipped during the availability test due
  to "unused arguments" warnings. To solve the issue, `-Werror-implicit-function-declaration`
  was added as a secondary flag, which is enough to guarantee the sanity of the testing process
  when it comes to testing the availability of certain intrinsics.
@charris charris added 08 - Backport Used to tag backport PRs component: SIMD Issues in SIMD (fast instruction sets) code or machinery 36 - Build Build related PR labels Aug 12, 2021
@charris charris added this to the 1.21.2 release milestone Aug 12, 2021
@charris charris merged commit 8045183 into numpy:maintenance/1.21.x Aug 12, 2021
@charris charris deleted the backport-19642 branch August 12, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
08 - Backport Used to tag backport PRs 36 - Build Build related PR component: SIMD Issues in SIMD (fast instruction sets) code or machinery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants