ENH: Add is_integer to np.floating & np.integer
#19803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BvB93
added
01 - Enhancement
62 - Python API
BvB93
commented
Aug 31, 2021
added 4 commits
August 31, 2021 17:42
BvB93
changed the title
is_integer to the np.floating subclasses is_integer to np.floating & np.integer
Co-Authored-By: Charles Harris <charlesr.harris@gmail.com>
|
Thanks Bas. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
builtins.floatclass currently contains a number of methods that are absent from its numpy-basedcounterparts (xref #13375). This PR alleviates this issue for
is_integer, which is now available tonp.floatingandnp.integersubclasses, matching builtin python.