BUG: Correct advance in PCG with emulated int128 #20049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do I need a release note? Probably should backport. |
I think so, if you can write a concise one that would be nice. It doesn't have to explain too much, it can link to the issue. |
rkern
approved these changes
Oct 6, 2021
Correct incorrect implemetation of carry in PCG64 and PCG64DXSM when advancing more than 2**64 steps closes numpy#20048
bashtage
force-pushed
the
pcg-advance-bug
branch
from
5e3b06e
to
401b26e
Compare
|
Thanks Kevin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct incorrect implemetation of carry in PCG64 and PCG64DXSM
when advancing more than 2**64 steps
closes #20048