BUG: Relax dtype identity check in reductions #20757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, e.g. ensure-native-byte-order will return not the default, but a copy of the descriptor. This (and maybe metadata) makes it somewhat annoying to ensure exact identity between descriptors for reduce "operands" as returned by the resolve-descirptors method of the ArrayMethod. To avoid this problem, we check for no-casting (which implies viewable with `offset == 0`) rather than strict identity. Unfortunately, this means that descriptor resolution must be slightly more careful, but in general this should all be perfectly well defined. Closes numpygh-20699
charris
added
00 - Bug
component: numpy._core
08 - Backport
This closes numpygh-20751, which was due to the assert not being noticed triggered (not sure why) during initial CI run. The behaviour is relaxed, so the assert must also be relaxed.
charris
force-pushed
the
backport-20729-20754
branch
from
c9c50ba
to
5163ab6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #20729 and #20754.
In some cases, e.g. ensure-native-byte-order will return not the
default, but a copy of the descriptor.
This (and maybe metadata) makes it somewhat annoying to ensure
exact identity between descriptors for reduce "operands" as
returned by the resolve-descirptors method of the ArrayMethod.
To avoid this problem, we check for no-casting (which implies
viewable with offset == 0) rather than strict identity.
Unfortunately, this means that descriptor resolution must be slightly
more careful, but in general this should all be perfectly well
defined.
Closes gh-20699. Closes gh-20751.