TYP: Relax the type of ndarray.__array_finalize__
#20768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BvB93
added
03 - Maintenance
08 - Backport
|
Thanks Bas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20756
Xref #20717
Changes the default type of the
ndarray.__array_finalize__attribute fromNonetoAny, this allowing subclasses to overwrite it with a method (without mypy complaining, that is). This is not the most ideal solution, but #20717 (comment) currently doesn't work due to what appears to be a mypy bug.Note that this is a 1.22.1-exclusive PR, as the concernes addressed above are irrelevant once #20766 is merged.