Commits on Jan 27, 2022

1. BUG: fix f2py's define for threading when building with Mingw …

   Closes rgommers/scipy#125
   This is a follow-up of numpygh-18910 (included in 1.20.3 and 1.21.0), which
   looks incorrect.
   
   This fixes warnings like these when building SciPy with Mingw-w64:
   ```
   [94/1557] Compiling C object scipy/linalg/_flapack.cp39-win_amd64.pyd.p/meson-generated_..__flapackmodule.c.obj
   In file included from C:\hostedtoolcache\windows\Python\3.9.9\x64\lib\site-packages\numpy\core\include/numpy/ndarraytypes.h:4,
                    from C:\hostedtoolcache\windows\Python\3.9.9\x64\lib\site-packages\numpy\core\include/numpy/ndarrayobject.h:12,
                    from C:\hostedtoolcache\windows\Python\3.9.9\x64\lib\site-packages\numpy\core\include/numpy/arrayobject.h:4,
                    from C:\hostedtoolcache\windows\Python\3.9.9\x64\lib\site-packages\numpy\f2py\src/fortranobject.h:13,
                    from scipy/linalg/_flapackmodule.c:16:
   scipy/linalg/_flapackmodule.c:1248:1: warning: 'thread' attribute directive ignored [-Wattributes]
    1248 | static F2PY_THREAD_LOCAL_DECL cb_cselect_in_gees__user__routines_t *_active_cb_cselect_in_gees__user__routines = NULL;
         | ^~~~~~
   scipy/linalg/_flapackmodule.c:1410:1: warning: 'thread' attribute directive ignored [-Wattributes]
    1410 | static F2PY_THREAD_LOCAL_DECL cb_zselect_in_gees__user__routines_t *_active_cb_zselect_in_gees__user__routines = NULL;
         | ^~~~~~
   scipy/linalg/_flapackmodule.c:1572:1: warning: 'thread' attribute directive ignored [-Wattributes]
    1572 | static F2PY_THREAD_LOCAL_DECL cb_sselect_in_gees__user__routines_t *_active_cb_sselect_in_gees__user__routines = NULL;
         | ^~~~~~
   scipy/linalg/_flapackmodule.c:1738:1: warning: 'thread' attribute directive ignored [-Wattributes]
    1738 | static F2PY_THREAD_LOCAL_DECL cb_dselect_in_gees__user__routines_t *_active_cb_dselect_in_gees__user__routines = NULL;
         | ^~~~~~
   
   ...
   ```
   
   Also fixes numpygh-19437, where `__STDC_NO_THREADS__` should be defined but
   isn't (this seems to be more common, e.g. one can reports for ICC about
   this).

   

   rgommers authored and charris committed Jan 27, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for b5bcf5e
   • Browse repository at this point

   Copy the full SHA

   b5bcf5e View commit details

   Browse the repository at this point in the history