-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT, DOC: make np._from_dlpack public #21145
Conversation
97087e9
to
bbf6993
Compare
Won't this break backwards compatibility? Perhaps we should keep both names for a bit while deprecating the underscored version. |
I didn't expect backward compatibility would be a concern for private methods (_from_dlpack wasn't even documented before). The reason we kept |
Co-authored-by: Matti Picus <matti.picus@gmail.com>
Co-authored-by: Matti Picus <matti.picus@gmail.com>
Could you add a note in doc/release/upcoming_changes? There is a README there which should explain how to add a |
Added the function to upcoming changes @mattip! |
LGTM. Let's wait a day or so to see if the mailing list discussion leads to changes. The rendered documentation can be seen here |
The one failure seems unrelated. |
Thanks @tirthasheshpatel |
fixes gh-20743
This PR:
np._from_dlpack
public.cc @seberg @mattip @leofang
@melissawm this might interest you :)