ENH: Add floating point error checking to (almost) all casts #21437
Commits on Jun 13, 2022
-
ENH: Check floating point error flags for all casts
To achieve this, I first need to propagate the ArrayMethod information that FPE flags _may_ be given for a specific cast. This requires quite a bit of changes (which is arguably the more annoying part of the PR/commit). Note that for some "legacy" casts, we do not modify this and assume that the only interesting information is `needs_api`.
-
-
-
-
WIP,TST: Add exhaustive test for FPEs in casts
unfortunately, I had to realize that float -> integer casts are not well defined when values are out of range for the integer. This is a problem with C, but means that neither the warnings seem to be particularly well defined... (I suspect, on my CPU it either warns OR gives "valid" integer overflow results, but the question is if that is even universally true...)
-
-
TST: Fix the weird boolean+advanced indexing test
The test meant to assert shapes, but didn't actually do it.
-
-
BUG: Fix needs_api for avanced assignments without subspace and remov…
…e unnecessary delay The delay is not necessary, because the iterator does not cast in any case, so we do not actually care about the possibility of errors being raised.
-
-
BUG: Avoid
NpyIter_EnableExternalLoopas it resets the bufferResetting the buffer will copy it, which may cause casting errors. And we want to prefer/catch those later ideally.
-
-
TST: Add final set of cast (and FPE in cast) test to ufuncs
The remaining uncovered paths seem to me like code that should be effectively unreachable. (I do actually wonder if `PyArray_MapIterReset` should be removed.)
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.