Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Mark npy_memchr with no_sanitize("alignment") on clang #21475

Merged
merged 1 commit into from May 9, 2022

Commits on May 9, 2022

  1. MAINT: Mark npy_memchr with no_sanitize("alignment") on clang

    Clangs sanitizer reports unaligned access here, which is correct
    but intentional.  It may well be that the code would be better of
    trying to avoid this unaligned access (and rather vectorizing harder).
    
    But, this is a bit of a tricky choice, since we have to optimize for
    different use-cases (in particular very short scans may be interesting).
    
    So changing this would best be done together with some more careful
    benchmarks.
    
    See also numpygh-21117, which introduced manual loop unrolling to avoid the
    unaligned access.
    
    Closes numpygh-21116
    seberg authored and charris committed May 9, 2022
    Configuration menu
    Copy the full SHA
    a8f4e78 View commit details
    Browse the repository at this point in the history