Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Proposal - make the doc landing page cards more similar to scipy #21512

Merged
merged 1 commit into from May 15, 2022

Conversation

charris
Copy link
Member

@charris charris commented May 15, 2022

Backport of #21491

This was discussed in the docs meeting and builds on #21456 . The proposal is to make the docs landing page look more like the pandas and scipy landing pages. The landing pages for these three projects already borrow heavily from one another - this PR just makes a few tweaks to bring numpy more in line stylistically with the other two. Main changes:

  • Match the card styling by dropping the card title background color and adding a button in the same style as scipy/pandas
  • Adds a link to the release notes to the top-level nav bar

There's also one minor maintenance issue: we're currently loading the custom css by extending the main layout template. AFAICT that is the only purpose that extending the layout template currently serves (the other additions have been commented out - see #17220). I think it's more straightforward to use the sphinx html_css_files config value to accomplish this rather than loading the css in the base template. I've made that change in 08ae8d3 but if there are objections I'm happy to break that out into a separate PR.

Also fixes #21264

…/pandas (numpy#21491)

* DOC: Add panel elements to index matching scipy/pandas.

* DOC: Update card styling in css to match scipy/pandas.

* DOC: Add release notes to nav bar.

* DOC: replace css in layout with html_css_files conf val.

* DOC: Fix page layout.

Co-authored-by: Stefan van der Walt <stefanv@berkeley.edu>

Co-authored-by: Stefan van der Walt <stefanv@berkeley.edu>
@charris charris added 04 - Documentation 08 - Backport Used to tag backport PRs labels May 15, 2022
@charris charris added this to the 1.22.4 release milestone May 15, 2022
@charris charris merged commit 5305a17 into numpy:maintenance/1.22.x May 15, 2022
@charris charris deleted the backport-21491 branch May 15, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
04 - Documentation 08 - Backport Used to tag backport PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants