New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEP: Remove normed=
keyword argument from histograms
#21645
Conversation
The normed keyword argument has been deprecated for a long time. This removes it, replacing its position with the new density argument.
normed=
keyword argument from histogromsnormed=
keyword argument from histograms
I decided to replace the positional argument. In theory, that changes behavior in those cases where If anyone has any concerns about that, we could potentially escalate or make the release note a bit clearer on that front. |
8768a92
to
40bd14d
Compare
I think the only case where the behavior would change would be if a user called the function with positional args and non-uniform bins, in which case the previous behavior was buggy and the new behavior is correct, so this seems fine to me 👍 |
Thanks Sebastian. |
The 1D case was well documented + warnning, but the 2D and nd cases appear to only have been documented as deprecated by reference and never warned. |
Hmmm, true, not sure I really realized this when doing this. Do you think we should "go back" to a deprecation for those? |
I got back-channel grumpy users claiming "no one in Python cares about back-compatibility" over this so maybe. However, given we are now over a year and 2 minor versions past this I'm not sure how many people who will be bit by this are left and of those how many won't be bit by it anyway (if they are lagging versions they likely won't jump to the newest version but go to 1.24 eventually). |
Oh, missed that there are 2 minor versions out there, so even the normal deprecation wouldn't have made a difference... I guess it is pretty much too late anyway, then. |
The normed keyword argument has been deprecated for a long time.
This removes it, replacing its position with the new density
argument.