Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: issue overflow warning when using abs on np.int8(-128) #21648

Merged
merged 18 commits into from
Jun 13, 2022
Merged

ENH: issue overflow warning when using abs on np.int8(-128) #21648

Changes from 3 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
511240f
ENH Issue overflow warning when using `abs` on `np.int8(-128)`
Micky774 Jun 2, 2022
1ef5d3d
Update numpy/core/src/umath/scalarmath.c.src
Micky774 Jun 2, 2022
756b852
Added safer check for overflow
Micky774 Jun 3, 2022
84bbdc8
Simplified check
Micky774 Jun 3, 2022
74e9aff
Merge branch 'main' into absolute_byte_overflow
Micky774 Jun 4, 2022
41aa046
Fixes/reenables test
Micky774 Jun 4, 2022
08e2d33
Added fperror check to `@type@_absolute`
Micky774 Jun 4, 2022
d8925f5
Linting
Micky774 Jun 4, 2022
ca8f199
Merge branch 'main' into absolute_byte_overflow
Micky774 Jun 10, 2022
5155f57
Removed extra FPError handling
Micky774 Jun 10, 2022
76e53ac
Merge branch 'main' into absolute_byte_overflow
Micky774 Jun 10, 2022
4c379d1
Fixed integer division FP_OVERFLOW
Micky774 Jun 10, 2022
3eac1ac
Typo
Micky774 Jun 10, 2022
19d84d7
Caught warnings for negating unsigned integers
Micky774 Jun 10, 2022
c513aa7
Merge branch 'main' into absolute_byte_overflow
Micky774 Jun 12, 2022
42adc88
Enabled tests
Micky774 Jun 12, 2022
754062a
Marked `xfail` for multiplication due to error on Windows
Micky774 Jun 12, 2022
3e692d8
MAINT: Revert change to division (and mark test as skip)
seberg Jun 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions numpy/core/src/umath/scalarmath.c.src
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,11 +582,15 @@ static NPY_INLINE int
/**begin repeat
* #name = byte, short, int, long, longlong#
* #type = npy_byte, npy_short, npy_int, npy_long, npy_longlong#
* #NAME = BYTE, SHORT, INT, LONG, LONGLONG#
*/
static NPY_INLINE int
@name@_ctype_absolute(@type@ a, @type@ *out)
{
*out = (a < 0 ? -a : a);
if (a < 0 && a == NPY_MIN_@NAME@) {
Micky774 marked this conversation as resolved.
Show resolved Hide resolved
return NPY_FPE_OVERFLOW;
}
Micky774 marked this conversation as resolved.
Show resolved Hide resolved
return 0;
}
/**end repeat**/
Expand Down