Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TYP, ENH: Add annotations for the equal_nan keyword to np.unique #21656

Merged
merged 1 commit into from
Jun 3, 2022
Merged

TYP, ENH: Add annotations for the equal_nan keyword to np.unique #21656

merged 1 commit into from
Jun 3, 2022

Conversation

BvB93
Copy link
Member

@BvB93 BvB93 commented Jun 3, 2022

Followup on #21646.

Adds annotations for the new equal_nan keyword to np.unique.

@BvB93 BvB93 added this to the 1.23.0 release milestone Jun 3, 2022
@charris charris merged commit ad186e3 into numpy:maintenance/1.23.x Jun 3, 2022
@charris
Copy link
Member

charris commented Jun 3, 2022

Thanks Bas. Will you do the forward port?

@BvB93 BvB93 deleted the nan branch June 3, 2022 15:03
@BvB93
Copy link
Member Author

BvB93 commented Jun 3, 2022

Thanks Bas. Will you do the forward port?

Yes, I'll create a PR either later today or tomorrow.
With the 1.23.0 release rapidly approaching I prioritized the backport over the forwardport, but I'll get to the latter soon.

@BvB93 BvB93 restored the nan branch June 3, 2022 15:18
@BvB93 BvB93 deleted the nan branch June 3, 2022 15:18
@BvB93 BvB93 mentioned this pull request Jun 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
01 - Enhancement Static typing
Projects
None yet
Milestone
1.23.0 release
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BvB93 @charris