CI: Guard compile-time CPU features tests #21766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seiko2plus
added
component: CI
component: SIMD
seiko2plus
force-pushed
the
ci_guard_cpu_features
branch
from
a3e6736
to
d1ce05a
Compare
This guard protects against any sudden unexpected changes that may adversely
affect the compile-time SIMD features detection which could leave the SIMD code
inactivated. Until now we have faced two cases:
1. Hardening the compile-time test files of Neon/ASIMD features without checking
the sanity of the modification leading to disabling all optimizations on aarch64.
see numpygh-21747
2. A sudden compiler upgrades by CI side on s390x that causes conflicts with the
installed assembler leading to disabling the whole VX/E features, which made us
merge SIMD code without testing it. Later, it was discovered that this code
disrupted the NumPy build.
see numpygh-21750, numpygh-21748
seiko2plus
force-pushed
the
ci_guard_cpu_features
branch
2 times, most recently
from
d82c8bd
to
91faeaa
Compare
|
Thanks @seiko2plus this should make it easier to see when compilation changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This guard protects against any sudden unexpected changes that may adversely
affect the compile-time SIMD features detection which could leave the SIMD code
inactivated. Until now we have faced two cases:
Hardening the compile-time test files of Neon/ASIMD features without checking
the sanity of the modification leading to disabling all optimizations on aarch64.
see Neon detection on M1 needs fixing for 1.23.0 release #21747
A sudden compiler upgrades by CI side on s390x that causes conflicts with the
installed assembler leading to disabling the whole VX/E features, which made us
merge SIMD code without testing it. Later, it was discovered that this code
disrupted the NumPy build.
see CI: Fix CI SIMD build on s390x #21750, BUG: Fix for npyv_orc_b8 and npyv_xnor_b8 for s390x (z13) #21748