ENH: add overflow handling for scalar negative operation
#21790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seberg
approved these changes
Jun 17, 2022
Co-authored-by: Sebastian Berg <sebastian@sipsolutions.net>
|
We are making various changes which I'm guessing will be flagged by some downstream package anytime soon. Should we release note all this somewhere? I can take it up as a separate PR to capture all this if needed. |
|
Thanks @Micky774, lets put this in. Yeah, good point @ganesh-k13. I think downstream already noticed, although it gets drowned a bit by the cast changes. |
|
Cool! I'll start work on it. For future reference, please tag all similar changes related to overflow to #21506 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues/PRs
Follow-up to #21648
Changes
Adds check to scalar
negativefor determining whether an overflow warning should be raised for signed integers. Improves testing fornegativeoperator on unsigned integers.Comments
N/A