Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Handle the value attribute in F2Py wrappers #21807

Merged
merged 3 commits into from Jul 2, 2022

Conversation

HaoZeke
Copy link
Member

@HaoZeke HaoZeke commented Jun 21, 2022

Closes #21665. The implementation essentially takes advantage of the existing machinery which is very similar to the handling of intent(c).

This should cover everything which is allowed by the standard since:

Character values, substrings, assumed-size arrays, and adjustable arrays cannot be passed by value. [source]

Might need a release note, but then again maybe not.

Copy link
Member

@melissawm melissawm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - should probably be documented somewhere, +1 to add a release note. Thanks @HaoZeke !

@charris
Copy link
Member

charris commented Jun 26, 2022

Needs a release note.

@HaoZeke HaoZeke requested a review from melissawm June 30, 2022 12:41
@melissawm melissawm merged commit eea02b0 into numpy:main Jul 2, 2022
@melissawm
Copy link
Member

Thanks @HaoZeke !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: f2py ignores value attribute
3 participants