-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Implement correct scalar and integer overflow errors for NEP 50 #21875
Merged
Merged
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
409cccf
ENH: Implement safe integers and weak python scalars for scalars
seberg d894650
ENH: Get correct integer conversion into ufuncs
seberg 0a0f96f
TST: Fix int overflow test for windows platforms where message differs
seberg 89cfcf0
MAINT: Use Python integers for int to array of uint32 calculation
seberg 2143cca
MAINT: Make mem-overlap tests weak scalar promotion ready
seberg fed11cd
BUG: Ensure new-style promotion is not accidentally used for some ints
seberg d47b09c
TST: Improve tests for python integer special cases
seberg c4f1419
TST: Rebustify NEP 50 integer tests for windows and 32bit linux
seberg d53a2b6
TST: Avoid possible warning from unnecessary cast with uninitialized …
seberg 0375d16
TST: Add test to cover complex to complex64 downcast in weak promotion
seberg 4ecc035
TST: Cover additional NEP 50 scalar paths
seberg d9da02d
DOC,TST: Improve overflow error message and adjust test
seberg ee3c20b
MAINT: Minor include fixup in scalarmath after rebase and comment fixup
seberg File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this line really skipped during testing or is codecoverage mistaken?