ENH: Add the capability to swap the singleton bit generator #21976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rkern A first attempt at an API for this. I followed the |
|
Random failure. |
|
This doesn't work because the C pointer from the capsule isn't changed when the Python attribute |
bashtage
force-pushed
the
enable-hot-swap
branch
from
011189c
to
affb903
Compare
|
@rkern thanks - I thought it was a property and didn't check (it once was). Added a cdef method to allow it to be set. |
bashtage
force-pushed
the
enable-hot-swap
branch
2 times, most recently
from
a148eeb
to
0c21d8f
Compare
mattip
reviewed
Jul 17, 2022
mattip
reviewed
Jul 17, 2022
mattip
reviewed
Jul 17, 2022
mattip
reviewed
Jul 17, 2022
mattip
reviewed
Jul 17, 2022
|
This seems like a reasonable thing to add. Is there anything to add around recommended best practices in the general numpy.random documentation? |
bashtage
force-pushed
the
enable-hot-swap
branch
from
493d031
to
a36d5ff
Compare
mattip
reviewed
Jul 17, 2022
|
cc: @emcastillo @kmaehashi for vis |
|
Needs rebase. |
Add a new version or seed that supports seeding any bit gen Add set/get_bit_generator as explicity methodds to support swapping closes numpy#21808
Fix typos and wrap length
Co-authored-by: Matti Picus <matti.picus@gmail.com>
bashtage
force-pushed
the
enable-hot-swap
branch
from
b5ac4da
to
69530cf
Compare
|
@charris rebased and green. |
|
Let's give this a shot. Thanks Kevin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new version or seed that supports seeding any bit gen
Add set/get_bit_generator as explicity methodds to support swapping
closes #21808