New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Distinguish exact vs. equivalent dtype for C type aliases. #21995
Merged
Commits on Jul 16, 2022
-
BUG: Distinguish exact vs. equivalent dtype for C type aliases.
For `asarray` and for the `dtype` equality operator, equivalent dtype aliases were considered exact matches. This change ensures that the returned array has a descriptor that exactly matches the requested dtype. Note: Intended behavior of `np.dtype('i') == np.dtype('l')` is to test compatibility, not identity. This change does not affect the behavior of `PyArray_EquivTypes()`, and the `__eq__` operator for `dtype` continues to map to `PyArray_EquivTypes()`. Fixes numpy#1468.
Configuration menu - View commit details
-
Copy full SHA for 45357de - Browse repository at this point
Copy the full SHA 45357deView commit details -
Configuration menu - View commit details
-
Copy full SHA for a3eedb0 - Browse repository at this point
Copy the full SHA a3eedb0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 78cd6b0 - Browse repository at this point
Copy the full SHA 78cd6b0View commit details -
Use the correct API call to actually set the base object.
Configuration menu - View commit details
-
Copy full SHA for 45281b8 - Browse repository at this point
Copy the full SHA 45281b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 81b9760 - Browse repository at this point
Copy the full SHA 81b9760View commit details -
Don't regenerate the descriptor unnecessarily.
Fix a false mismatch. Separate dtype objects, even if equivalent, cause distinct array views to be created.
Configuration menu - View commit details
-
Copy full SHA for 871a1f9 - Browse repository at this point
Copy the full SHA 871a1f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5651445 - Browse repository at this point
Copy the full SHA 5651445View commit details
Commits on Jul 17, 2022
-
* Improve comments/docs. * Improve descriptiveness of variable names. * Add additional test expressions that would not pass without this patch.
Configuration menu - View commit details
-
Copy full SHA for e286f46 - Browse repository at this point
Copy the full SHA e286f46View commit details -
Configuration menu - View commit details
-
Copy full SHA for 01438a8 - Browse repository at this point
Copy the full SHA 01438a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for b1a8ff8 - Browse repository at this point
Copy the full SHA b1a8ff8View commit details
Commits on Sep 3, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 235b75e - Browse repository at this point
Copy the full SHA 235b75eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.