Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: drop older cygwin compatibility shims #22159

Merged
merged 2 commits into from Aug 21, 2022
Merged

Conversation

mattip
Copy link
Member

@mattip mattip commented Aug 21, 2022

Continuation of #22139, see this comment

xref @DWesl

@mattip mattip added the 56 - Needs Release Note. Needs an entry in doc/release/upcoming_changes label Aug 21, 2022
@mattip mattip removed the 56 - Needs Release Note. Needs an entry in doc/release/upcoming_changes label Aug 21, 2022
@DWesl
Copy link
Contributor

DWesl commented Aug 21, 2022

It will probably be clearer to refer to Cygwin 3.3 rather than Cygwin DLL major version 3003, at least in the release notes, since the first one is what uname -r and the package manager show. Otherwise looks good.

@DWesl
Copy link
Contributor

DWesl commented Aug 21, 2022

It looks like the Azure failure amounts to "Azure had problems". The changes look good.

@rgommers rgommers added this to the 1.24.0 release milestone Aug 21, 2022
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too, in it goes. Thanks @mattip, and thanks @DWesl for the review.

@rgommers rgommers merged commit a36783e into numpy:main Aug 21, 2022
@mattip mattip deleted the cygwin-versions branch December 27, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants