New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT, CI: Update Ubuntu 18.04 to Ubuntu 20.04 #22598
Conversation
81d81fc
to
d356f74
Compare
Hmm, build error running "full" on azure:
|
be3882f
to
f870b36
Compare
Coverage fails in Ubuntu 20.04, but works in 22.04. Unfortunately, there are a lot of error like this:
See https://github.com/numpy/numpy/actions/runs/3474938876/jobs/5808717885 for more. The |
Github actions will drop support for 18.04 April 1, 2023. There are now sporadic test cancelations due to warning brownouts, and the NumPy 1.24.x release will overlap that date, so increase the Ubuntu version. The main change here is that there is no support for gcc-6 in Ubuntu 20.04, so testing with that version is also dropped.
f5b36da
to
6736c78
Compare
LGTM, but not merging since I am not sure if you want to take a shot at fix the coverage warnings this first. Do we need to document that GCC 6 is not officially tested anymore? |
Since that is fixed in Ubuntu 22.04, I'm not going to worry about it. The warnings in that version are unrelated and due to the
Good point. I'll add a release note, but not sure what section to put it in. |
Maybe just "compatibility" if we are talking release notes? Seems OK, and we can still move it if desired. |
We have dropped GCC-6 build testing.
OK, lets put this in, thanks Chuck. Was there something to followup on if the warning fixes work out? |
Github actions will drop support for 18.04 April 1, 2023. There are now sporadic test cancelations due to warning brownouts, and the NumPy 1.24.x release will overlap that date, so increase the Ubuntu version.
The main change here is that there is no support for gcc-6 in Ubuntu 20.04, so testing with that version is dropped.