Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: use -ftrapping-math with Clang on macOS #24182

Merged
merged 1 commit into from
Jul 14, 2023

Commits on Jul 14, 2023

  1. BLD: use -ftrapping-math with Clang on macOS

    The distutils build also uses this flag, and it avoids some problems
    with `floor_divide` and similar functions (xref numpygh-19479).
    
    For older macOS arm64 Clang versions, the flag does get accepted, but then
    gets overridden because it's not actually supported - which yields these
    warnings:
    ```
    warning: overriding currently unsupported use of floating point exceptions on this target [-Wunsupported-floating-point-opt]
    ```
    Since they're a little annoying to suppress and will go away when updating to
    the latest XCode version, we'll ignore these warnings.
    rgommers authored and charris committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    621390f View commit details
    Browse the repository at this point in the history