MAINT: fix version string in wheels built with setup.py #24748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
licy183
changed the title
Since numpy 1.26.0, when building with setup.py, the building system generates a weird verion string 1.26.1.26.0. Commit a880c68 has a logical error when doing some code clean-up. This generates the abnormal version string 1.26.01.26.0, and then setuptools normalized this string as 1.26.1.26.0.
|
Seems right to me, here is the old code. Since we removed setup.py we cannot test the fix on HEAD. But I can confirm that |
|
Thanks @licy183. Please move to using the more modern workflow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since numpy 1.26.0, when building with setup.py, the building system generates a weird verion string 1.26.1.26.0. Commit a880c68 has a logical error when doing some code clean-up. This generates the abnormal version string 1.26.01.26.0, and then setuptools normalized this string as 1.26.1.26.0.