ENH: add parameter strict to assert_equal
#24770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the parameter strict to np.testing.assert_equal. With strict=True, the shape and dtype of the two arguments must match for the assertion to pass.
mdhaber
changed the title
strict to assert_equal
mdhaber
commented
Sep 21, 2023
| @@ -232,22 +232,22 @@ def test_array_vs_scalar_strict(self): | |||
| b = 1. | |||
|
|
|||
| with pytest.raises(AssertionError): | |||
| assert_array_equal(a, b, strict=True) | |||
| self._assert_func(a, b, strict=True) | |||
There was a problem hiding this comment.
TestEqual, the class used to test assert_equal, inherits from this class. This class is TestArrayEqual, which is used to test assert_array_equal.)
Before this PR, these three tests of the strict parameter would run twice - once for TestArrayEqual, and once for TestEqual - but assert_array_equal was tested both times. Now, these will test the appropriate assertion function each time they run.
These were the only tests of the strict parameter added when the strict parameter was added to assert_array_equal in gh-21595. If they were sufficient there, hopefully enabling them for assert_equal is sufficient here.
|
LGTM. I will merge it soon if no-one else has any comments. |
|
Thanks @mdhaber |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the parameter
stricttonp.testing.assert_equal. Withstrict=True, the shape and dtype of the two arguments must match for the assertion to pass.Follows the example of #21595
Partially addresses suggestion in #24667 (comment)
Addresses #24680 (comment)