-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI, MAINT: Add docs-only option to CI #26316
base: main
Are you sure you want to change the base?
Conversation
Borrows logic from SciPy CI Co-authored-by: Lucas Colley <lucas.colley8@gmail.com>
[skip azp][skip cirrus][skip actions]
@@ -13,7 +13,12 @@ permissions: | |||
contents: read # to fetch code (actions/checkout) | |||
|
|||
jobs: | |||
get_commit_message: | |||
name: Get commit message | |||
uses: ./.github/workflows/commit_message.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This already skips the run if not docs-only, right? Can we encode that into the name?
In general, I think having [docs only]
is awesome (a github label might also be, easier to add by maintainer, but a different thing).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, the naming in SciPy is historical as an existing job was modified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thought I would ping since I just saw a suggestion to add the three skips we currently need.
Not sure if there is anything else holding it up. But, assuming it works, from my side it seems ready with that rename to clarify what the needs:
does below.
@melissawm ping |
Sorry for the delay - these are not working in my fork which is why I'm holding it up. Will try to test again. |
Borrows logic from SciPy CI skip checks implemented by @lucascolley
I will test on my own fork first before marking as ready for review, but if you have corrections or suggestions already please let me know.
See #26311 (comment)