Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Convert loop unary fp into highway #26346

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

ENH: Convert loop unary fp into highway #26346

wants to merge 17 commits into from

Conversation

luyahan
Copy link

@luyahan luyahan commented Apr 25, 2024 •
edited

refer #24384, #24385

x64 Intel(R) Xeon(R) Gold 6278C CPU @ 2.60GHz benchmark
macos m1 benchmark

@luyahan luyahan changed the title rewrite loop rint into HIGHWAY ENH: Convert loop fp rint into highway Apr 25, 2024
@luyahan luyahan changed the title ENH: Convert loop fp rint into highway ENH: Convert loop unary fp rint into highway Apr 25, 2024
@luyahan luyahan changed the title ENH: Convert loop unary fp rint into highway WIP: ENH: Convert loop unary fp rint into highway Apr 25, 2024
@luyahan luyahan changed the title WIP: ENH: Convert loop unary fp rint into highway [WIP]ENH: Convert loop unary fp rint into highway Apr 25, 2024
@Mousius
Copy link
Member

Mousius commented Apr 30, 2024

Hi @luyahan,

Have you measured if this changes/increases performance? Would be good to see some benchmarks 😸

Just a process point, I assume google/highway#2116 needs to be released before this can be merged?

@luyahan luyahan force-pushed the rint-hwy branch 2 times, most recently from c0e7346 to 86eddd1 Compare May 6, 2024 06:10
@Mousius Mousius added the component: SIMD Issues in SIMD (fast instruction sets) code or machinery label May 6, 2024
@luyahan
Copy link
Author

luyahan commented May 7, 2024 •
edited

Hi @luyahan,

Have you measured if this changes/increases performance? Would be good to see some benchmarks 😸

Just a process point, I assume google/highway#2116 needs to be released before this can be merged?

benchmark https://paste.ubuntu.com/p/4SYzpt7BXT/

@luyahan
Copy link
Author

luyahan commented May 7, 2024 •
edited

Just a process point, I assume google/highway#2116 needs to be released before this can be merged?

Yes, google/highway#2116 has been merged.😁

@r-devulap
Copy link
Member

121 tests fail https://dev.azure.com/numpy/numpy/_build/results?buildId=36327&view=logs&j=bb985aa7-6f2e-5862-34d1-fe760a3f4424&t=fedaa2b4-fa4d-5ee0-669f-9fb1714eeeb2 Have you looked into these yet?

@r-devulap r-devulap self-assigned this May 8, 2024
@luyahan
Copy link
Author

luyahan commented May 9, 2024 •
edited

121 tests fail https://dev.azure.com/numpy/numpy/_build/results?buildId=36327&view=logs&j=bb985aa7-6f2e-5862-34d1-fe760a3f4424&t=fedaa2b4-fa4d-5ee0-669f-9fb1714eeeb2 Have you looked into these yet?

May be highway dipatch func on SSE2 target.
Where can i find the cpu nfo of the windows ci? I have only i5-13500H windows.

@luyahan luyahan changed the title [WIP]ENH: Convert loop unary fp rint into highway [WIP]ENH: Convert loop unary fp into highway May 9, 2024
@luyahan luyahan force-pushed the rint-hwy branch 2 times, most recently from 01d1854 to 644b255 Compare May 13, 2024 02:28
@luyahan luyahan changed the title [WIP]ENH: Convert loop unary fp into highway ENH: Convert loop unary fp into highway May 13, 2024
@luyahan luyahan requested a review from r-devulap May 13, 2024 02:43
@luyahan
Copy link
Author

luyahan commented May 15, 2024

121 tests fail https://dev.azure.com/numpy/numpy/_build/results?buildId=36327&view=logs&j=bb985aa7-6f2e-5862-34d1-fe760a3f4424&t=fedaa2b4-fa4d-5ee0-669f-9fb1714eeeb2 Have you looked into these yet?

Hi
I had fixed all on win.

@mattip
Copy link
Member

mattip commented May 30, 2024

There are still failing tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-devulap r-devulap Awaiting requested review from r-devulap

Requested changes must be addressed to merge this pull request.

Assignees

@r-devulap r-devulap

Labels
component: SIMD Issues in SIMD (fast instruction sets) code or machinery
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@luyahan @Mousius @r-devulap @mattip