Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Fix build when using scipy-openblas wheels #26437

Merged
merged 1 commit into from
May 15, 2024

Conversation

mattip
Copy link
Member

@mattip mattip commented May 15, 2024

The helper file will only be created when using spin --with-scipy-openblas. When using a workflow that builds from source, the helper file is not created and the build will fail:

pip install scipy-openblas32
python -c 'import scipy_openblas32; print(scipy_openblas32.get_pkg_config())' > ./scipy-openblas.pc
export PKG_CONFIG_PATH=$PWD
pip install  --no-binary :numpy: numpy==1.26.5

This should fix the problem. Skipping CI since this problem is not hit by current CI.

@mattip mattip added the 08 - Backport Used to tag backport PRs label May 15, 2024
@mattip
Copy link
Member Author

mattip commented May 15, 2024

I don't know if another 1.26.x is planned, but if so it would be nice to have this.

@charris
Copy link
Member

charris commented May 15, 2024

I don't know if another 1.26.x is planned

We can no longer make 1.26.x wheels for macosx m1. Cirrus upgraded the tool chain and fixing it seemed more work than justified by the accumulated backports.

@charris charris merged commit ba369e3 into numpy:maintenance/1.26.x May 15, 2024
3 checks passed
@charris
Copy link
Member

charris commented May 15, 2024

Thanks Matti, I put it in just in case.

@charris charris changed the title Fix build when using scipy-openblas wheels MAINT: Fix build when using scipy-openblas wheels May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
03 - Maintenance 08 - Backport Used to tag backport PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants