restore cursor shape when exits

[nibon7]

Description

This PR restores cursor shape when nushell exists.

Fixes #9243

Related nushell/reedline#574

User-Facing Changes

• windows

windows_ps.mp4

• linux

linux_alacritty.mp4

• macos

mac_iterm2.mp4

Tests + Formatting

After Submitting

[fdncred]

Seems reasonable. I'm guessing from the code that the drop(line_editor) is what is resetting the cursor? What happens on panic? What happens with parameters like -c?

[nibon7]

I'm guessing from the code that the drop(line_editor) is what is resetting the cursor?

Yeah, when the reedline object is destructed, cursor shape will be reset.

What happens on panic?

When a panic occurs, stack unwinding is triggered. During the stack unwinding process, the destructor functions of objects that implement the Drop trait will be called.

If the reedline object still exists on the stack when a panic occurs, the destructor will be executed and the cursor shape will be reset.

If you set "panic=abort" in Cargo.toml, when a panic occurs, nushell will immediately abort rather than perform any further cleanup, and the cursor shape will not be reset.

What happens with parameters like -c?

This change has nothing to do with it as nu -c invokes evaluate_commands which doesn't create a Reedline instance and the cursor never changed.

PS: nu /path/to/script.nu doesn't create a Reedline instance too.

[fdncred]

Ok, thanks for the hard work and research @nibon7. Let's give this a try.