Tx: var err is not assigned at all (fixup) #583
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The buggy code declared `var err`, but never assigned to it. so the `if err != nil` will always be false, and the error case was missed. Signed-off-by: Park Zhou <ideapark@139.com>
|
could you solve the conflicts and push it again, thanks! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #583 +/- ##
=======================================
Coverage 73.07% 73.07%
=======================================
Files 37 37
Lines 5604 5604
=======================================
Hits 4095 4095
Misses 1105 1105
Partials 404 404 ☔ View full report in Codecov by Sentry. |
|
I think the PR #582 has fixed this bug unintentially, so close this PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The buggy code declared
var err, but never assigned to it. so theif err != nilwill always be false, and the error case was missed.Signed-off-by: Park Zhou ideapark@139.com