-
-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for multiple where directives #834
Conversation
@cwhitby I realized this problem is twofold. While i adapted the handling of Thanks for the PR, i am working on a generalized fix. |
Actually, the GraphQL specification declares that directives must be unique per location. There is an ongoing RFC to allow repeatable directives: graphql/graphql-spec#472 |
# Conflicts: # src/Execution/Builder.php
@spawnia you should review this again, as afaik repeatable directives are now officially supported by the spec: https://github.com/graphql/graphql-wg/blob/master/notes/2019-10-10.md#repeatable-directives-ivan-10m |
@Jofairden thanks, I am aware. Added support in |
@cwhitby the test is working now, since we changed some logic around that makes it function correctly. Also tried your original test Merging this for now. |
Former-commit-id: 3ab416c
Related Issue/Intent
References #831
Changes
No code changes, only adding a test for applying multiple
@where
directives on the same fieldBreaking changes
None