fix(schemes): OAuth urls are not formatted properly if they have a query parameter #1868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like there's a PR already (#1832), but was created a year ago and has not been merged. I'm keeping the PR for now. |
baluyotraf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
We are using an AzureB2C for our authentication and they provide their URLS with a query parameters. This breaks the sections I fixed with the way the OAuth query parameters are appended to the url.
Here's the OpenIDC Configuration if you're curious: https://alvb2ctest.b2clogin.com/ALVB2CTEST.onmicrosoft.com/v2.0/.well-known/openid-configuration?p=B2C_1A_ALV_ASCP_SIGNUP_SIGNIN
I only provide a short way to do it, but if there's a recommended way to fix it, I can work on it that way.