Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(createRouter): Add the store parameter to the customCreateRouter function #105

Merged

Conversation

loick
Copy link
Contributor

@loick loick commented Aug 23, 2021

Nuxt release 2.16 nuxt/nuxt#9660

Related commit:
nuxt/nuxt#9629

Context: The router now supports a "store" parameter (starting the Nuxt 2.16 release).

@codecov
Copy link

codecov bot commented Aug 23, 2021

Codecov Report

Merging #105 (428d4e7) into main (18bb2d3) will not change coverage.
The diff coverage is n/a.

❗ Current head 428d4e7 differs from pull request most recent head 1c365ea. Consider uploading reports for the commit 1c365ea to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##              main      #105   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           21        21           
  Branches         4         4           
=========================================
  Hits            21        21           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18bb2d3...1c365ea. Read the comment docs.

@loick
Copy link
Contributor Author

loick commented Aug 24, 2021

I'll come back here to merge this PR once the nuxt release will be done, if it's fine by you @danielroe, in order to merge this (& release afterwards?)

Thanks 🙏

@loick
Copy link
Contributor Author

loick commented Nov 10, 2021

@danielroe what do you think about releasing it now, in order to be able to use it with nuxt-edge?

@loick
Copy link
Contributor Author

loick commented Nov 23, 2021

@danielroe is it possible?

@danielroe danielroe requested a review from pi0 December 1, 2021 16:31
@danielroe
Copy link
Member

danielroe commented Dec 1, 2021

I think it isn't a breaking change. What do you think @pi0 @ricardogobbosouza?

@ricardogobbosouza
Copy link
Member

I also don't think it's a breaking change.

@ricardogobbosouza
Copy link
Member

@loick
I think it's valid update the documents
https://github.com/nuxt-community/router-module#accessing-default-router

@loick
Copy link
Contributor Author

loick commented Dec 6, 2021

okay @ricardogobbosouza, done

@ricardogobbosouza ricardogobbosouza merged commit d068f6e into nuxt-community:main Dec 6, 2021
@loick
Copy link
Contributor Author

loick commented Dec 9, 2021

Thank you! How can we bump this library in order to get this code into the latest version of this nuxt module?

@Atinux
Copy link
Member

Atinux commented Dec 15, 2021

ping @ricardogobbosouza

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants