New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(createRouter): Add the store parameter to the customCreateRouter function #105
feat(createRouter): Add the store parameter to the customCreateRouter function #105
Conversation
Codecov Report
@@ Coverage Diff @@
## main #105 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 21 21
Branches 4 4
=========================================
Hits 21 21 Continue to review full report at Codecov.
|
I'll come back here to merge this PR once the nuxt release will be done, if it's fine by you @danielroe, in order to merge this (& release afterwards?) Thanks 🙏 |
@danielroe what do you think about releasing it now, in order to be able to use it with |
@danielroe is it possible? |
I think it isn't a breaking change. What do you think @pi0 @ricardogobbosouza? |
I also don't think it's a breaking change. |
@loick |
okay @ricardogobbosouza, done |
Thank you! How can we bump this library in order to get this code into the latest version of this nuxt module? |
ping @ricardogobbosouza |
Nuxt release 2.16 nuxt/nuxt#9660
Related commit:
nuxt/nuxt#9629
Context: The router now supports a "store" parameter (starting the Nuxt 2.16 release).